Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add support for nullable and optional types in go #1939

Merged
merged 10 commits into from
Apr 25, 2024
Merged

feat!: add support for nullable and optional types in go #1939

merged 10 commits into from
Apr 25, 2024

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Apr 15, 2024 •
edited
Loading

Description

Adding support for nullable and required object for golang

Related Issue

Fixes #1418

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

@netlify Netlify
Copy link

netlify bot commented Apr 15, 2024 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit e5557a2
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/662a1d2538206e000886e192

@Souvikns Souvikns changed the title feat: go feat: add support for nullable and required object in go Apr 18, 2024
@Souvikns Souvikns marked this pull request as ready for review April 22, 2024 06:33
jonaslagoni
jonaslagoni requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you have a failing CI, just had one comment otherwise ✌️

docs/migrations/version-3-to-4.md Outdated Show resolved Hide resolved
@jonaslagoni jonaslagoni changed the title feat: add support for nullable and required object in go feat: add support for nullable and optional types in go Apr 23, 2024
jonaslagoni
jonaslagoni requested changes Apr 23, 2024
View reviewed changes
src/generators/go/GoConstrainer.ts Outdated Show resolved Hide resolved
test/generators/go/GoConstrainer.spec.ts Outdated Show resolved Hide resolved
test/generators/go/GoGenerator.spec.ts Show resolved Hide resolved
@jonaslagoni jonaslagoni changed the title feat: add support for nullable and optional types in go feat!: add support for nullable and optional types in go Apr 24, 2024
jonaslagoni
jonaslagoni approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jonaslagoni
Copy link
Member

/rtm

@Souvikns
Copy link
Member Author

@jonaslagoni black box testing is failing, what to do for that.

jonaslagoni
jonaslagoni requested changes Apr 25, 2024
View reviewed changes
src/generators/go/GoConstrainer.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Souvikns Souvikns requested a review from jonaslagoni April 25, 2024 09:35
jonaslagoni
jonaslagoni approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni jonaslagoni merged commit 3882de5 into asyncapi:next Apr 25, 2024
16 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

jonaslagoni pushed a commit to jonaslagoni/generator-model-sdk that referenced this pull request Apr 29, 2024
@Souvikns @jonaslagoni
feat!: add support for nullable and optional types in go (asyncapi#1939)
d2fa78a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Souvikns @jonaslagoni @asyncapi-bot