fix: type are not determined in cyclic models

[jonaslagoni]

Description

As #1903 explains, the underlying problem occurs because of the way we constrain models and their types, basically doing both at the same time.

This means that when we have circular models and they depend on each other, and the type has not been set yet, but we expect it to, we end up with the type having the value ''. I.e. why we end up with self._items: | List[] = input['items'] where the union model that items reference has not been sat when we set the item's type.

With this change in approach, we first build the constrained model (with any value that makes sense at the factory time), and then we apply types based on "safe types" first, and once those have been resolved, if we detect a circular model, we open it up by replacing it with AnyModel, and apply the more complex types automatically.

For example;

• Model a: Union model with Model b
• Model b: Union model with Model a

In such case we are unable to render the type, cause each depends on each other to determine the type.

The algorithm currently adapts the models so we end up with;

• Model a: Union model with Model b
• Model b: Union model with any model

Lastly, we then apply constants and discriminatory values (because they depend on type).

I would have loved to find a better way to do this implementation, but this is the best my bandwidth has come up with for the past weeks...

The reason this is not a breaking change is because it fixes types just being generated with '' values, and therefore this corrects that incorrect syntax. If a type would have been generated, this would have been a breaking change.

Fixes #1903
Blocked by #1893

[netlify]

✅ Deploy Preview for modelina canceled.

Name	Link
🔨 Latest commit	feac4af
🔍 Latest deploy log	https://app.netlify.com/sites/modelina/deploys/662f79a0d253b40008e6efa2

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[asyncapi-bot]

🎉 This PR is included in version 4.0.0-next.36 🎉

The release is available on:

• npm package (@next dist-tag)
• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀