-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add json serialisation support for golang #1848
Conversation
✅ Deploy Preview for modelina canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment for the implementation 👍 Looking good 💪
Remember to do parts 4 and 5 of https://github.com/asyncapi/modelina/blob/master/docs/contributing.md#adding-a-new-preset
test/generators/go/presets/__snapshots__/CommonPreset.spec.ts.snap
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 8183449856Details
💛 - Coveralls |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/rtm |
/rtm |
@all-contributors please add @Souvikns for code, test, example, docs |
I've put up a pull request to add @Souvikns! 🎉 |
🎉 This PR is included in version 4.0.0-next.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR is adding JSON serialization support by adding struct tags while generating go structs, by creating a new
GO_PRESET
.Also adds custom marshaler functions for enums when generating
struct-tags
Related Issue
Fixes #299
Checklist
npm run lint
).npm run test
).Additional Notes