Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed highlight in docs #1721

Merged

Conversation

officialasishkumar
Copy link
Contributor

@officialasishkumar officialasishkumar commented Jan 4, 2024

Description

Fix highlight when selected and hovered in docs of modelina 😃

Related Issue

Fixes #1719

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 99dbf7b
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/659972aa4cb01b0008a7801a
😎 Deploy Preview https://deploy-preview-1721--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@officialasishkumar
Copy link
Contributor Author

@jonaslagoni Please take a look : )

@coveralls
Copy link

coveralls commented Jan 4, 2024

Pull Request Test Coverage Report for Build 7432454036

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.364%

Totals Coverage Status
Change from base Build 7432363294: 0.0%
Covered Lines: 5869
Relevant Lines: 6193

💛 - Coveralls

@devilkiller-ag
Copy link
Member

Hi @officialasishkumar, can you check why the tests are failing?

@officialasishkumar officialasishkumar changed the title Fix highlight selected doc docs:fixed highlight in docs Jan 4, 2024
@officialasishkumar officialasishkumar changed the title docs:fixed highlight in docs docs: fixed highlight in docs Jan 4, 2024
@officialasishkumar
Copy link
Contributor Author

officialasishkumar commented Jan 4, 2024

Hi @officialasishkumar, can you check why the tests are failing?

PR title. Can you re-run the test ?

Copy link

sonarqubecloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jonaslagoni
Copy link
Member

@devilkiller-ag can you take another look 🙂

@devilkiller-ag
Copy link
Member

Seems good to me!

@devilkiller-ag
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit e4c4d6c into asyncapi:master Jan 9, 2024
16 checks passed
officialasishkumar added a commit to officialasishkumar/modelina that referenced this pull request Jan 11, 2024
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix highlight selected doc in website
5 participants