-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecated Website Shop Link in Footer #1708
Conversation
✅ Deploy Preview for modelina ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 7367252547
💛 - Coveralls |
Hey @ devansh-m12, @ anchalpanwar17 was already working on it. @anchalpanwar17 Have you started working on this issue (#1666)? If not would you like to transfer it to @devansh-m12? @devansh-m12 I would suggest you inform us that you would like to work on an issue before starting work on it. |
@devilkiller-ag ohh my bad, I'll make sure to remember that (I had not seen Assignees on that 😅) . should i close this pr ? |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@devilkiller-ag as there has been no specific response from the other two, and this PR is already up, I would vote to just merge/review this one 🙂 What matters is creating the PR, not so much saying you want to do it. However, @devansh-m12 it is good practice to let others have some days when they say they wanted to complete it, before doing the issue yourself 😄 Just so no one is wasting time is the most important one 👍 |
Hi @devansh-m12 @jonaslagoni, This issue was previously solved by the PR #1705 |
Description
This pull request addresses the issue of a deprecated website shop link in the footer section of the site. The current link is pointing to an outdated URL, leading to a irrelevant page. This PR updates the link to ensure users are directed to the correct and up-to-date shop page.
Related Issue
[website bug]: update the link to async api Shop in the footer section of website](#1666)
Changes Made