Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated Website Shop Link in Footer #1708

Closed
wants to merge 2 commits into from
Closed

fix: deprecated Website Shop Link in Footer #1708

wants to merge 2 commits into from

Conversation

devansh-m12
Copy link
Contributor

Description

This pull request addresses the issue of a deprecated website shop link in the footer section of the site. The current link is pointing to an outdated URL, leading to a irrelevant page. This PR updates the link to ensure users are directed to the correct and up-to-date shop page.

Related Issue

[website bug]: update the link to async api Shop in the footer section of website](#1666)

Changes Made

  • Updated the website shop link in the footer to the new, correct URL.
  • Ensured that the link now points to the relevant and active shop page.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6590b833522574be2d4b021a
😎 Deploy Preview https://deploy-preview-1708--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devansh-m12 devansh-m12 changed the title fix : deprecated Website Shop Link in Footer fix: deprecated Website Shop Link in Footer Dec 28, 2023
@coveralls
Copy link

coveralls commented Dec 28, 2023

Pull Request Test Coverage Report for Build 7367252547

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.33%

Totals Coverage Status
Change from base Build 7367213759: 0.0%
Covered Lines: 5867
Relevant Lines: 6193

💛 - Coveralls

@devilkiller-ag
Copy link
Member

Hey @ devansh-m12, @ anchalpanwar17 was already working on it. @anchalpanwar17 Have you started working on this issue (#1666)? If not would you like to transfer it to @devansh-m12? @devansh-m12 I would suggest you inform us that you would like to work on an issue before starting work on it.

@devansh-m12
Copy link
Contributor Author

devansh-m12 commented Dec 28, 2023

@devilkiller-ag ohh my bad, I'll make sure to remember that (I had not seen Assignees on that 😅) . should i close this pr ?

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jonaslagoni
Copy link
Member

jonaslagoni commented Dec 31, 2023

@devilkiller-ag as there has been no specific response from the other two, and this PR is already up, I would vote to just merge/review this one 🙂

What matters is creating the PR, not so much saying you want to do it. However, @devansh-m12 it is good practice to let others have some days when they say they wanted to complete it, before doing the issue yourself 😄 Just so no one is wasting time is the most important one 👍

@devansh-m12 devansh-m12 closed this by deleting the head repository Dec 31, 2023
@devilkiller-ag
Copy link
Member

Hi @devansh-m12 @jonaslagoni, This issue was previously solved by the PR #1705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants