-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding Scala generator #1665
Conversation
✅ Deploy Preview for modelina canceled.
|
The PR is WIP ... |
Pull Request Test Coverage Report for Build 7308436291
💛 - Coveralls |
Let me know if you need anything from me @artur-ciocanu 🤙 Looking forward to having this! |
@artur-ciocanu you can ignore sonar duplication warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing left to do as I see is adding simple generate example: https://github.com/asyncapi/modelina/tree/master/examples/generate-java-models
There is a template you can copy and change 🙂
9287ec4
to
ad94e42
Compare
Quality Gate failedFailed conditions 7.2% Duplication on New Code (required ≤ 3%) |
@jonaslagoni it seems that I have covered everything that is required for Scala code gen. Once this PR is out, I'll add some JSON serialization preset and Jakarta validation preset. Let me know your thought and if there is anything else required. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @artur-ciocanu, thanks for taking the time to provide it 🤙 Got a couple of small things that needs to be added, but Ill create issues after, not required to merge 😄
Also, do you want to become the codeowner of the scala generator, or are you only looking to donate it? ✌️
/rtm |
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @artur-ciocanu for code, example, docs, test |
I've put up a pull request to add @artur-ciocanu! 🎉 |
@jonaslagoni I can be a code owner, I would like to get rid of my "internal" fork and just maintain the official Modelina version. Thanks for merging it! |
Awesome, thanks for doing it! Added a PR to add you 🤙 #1686 |
🎉 This PR is included in version 3.0.0-next.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Related issue(s)
Resolves #1664