Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(website): rewrite class-based functional components #1655

Merged
merged 18 commits into from
Dec 13, 2023

Conversation

devilkiller-ag
Copy link
Member

Description
The current codebase of the Playground Generator Options, Docs, and Examples Components of the Modelina Website contained class-based react components. I have updated the code base to use functional components and hooks at all places. This results in cleaner, easier-to-understand components compared to class components.

Related issue(s)
Fixes #1648

Note
This PR is to replace PR #1649 which just got destroyed by Pull bot.

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 3618923
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6579faf6064b570008af17c9
😎 Deploy Preview https://deploy-preview-1655--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.3% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@coveralls
Copy link

coveralls commented Dec 13, 2023

Pull Request Test Coverage Report for Build 7199651254

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.516%

Totals Coverage Status
Change from base Build 7195538757: 0.0%
Covered Lines: 5600
Relevant Lines: 5901

💛 - Coveralls

@jonaslagoni jonaslagoni changed the title refactor(website): rewrite class-based react components to functional components in website refactor(website): rewrite class-based functional components Dec 13, 2023
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jonaslagoni
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit af95064 into asyncapi:master Dec 13, 2023
18 of 19 checks passed
@devilkiller-ag devilkiller-ag deleted the ag-dev-comeback branch December 13, 2023 18:53
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Class-Based React Components to Functional Components in Modelina Website
4 participants