Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(website): add generic playground options #1309

Merged
merged 12 commits into from
May 30, 2023
Merged

chore(website): add generic playground options #1309

merged 12 commits into from
May 30, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented May 22, 2023 •
edited
Loading

Description
This PR adds the following changes to the playground:

  • Adds 5 new generic options, for all generators:
    • Checkbox to include a simple example of a custom type mapping for integer model.
    • Dropbox for changing indentation type
    • Dropbox for changing a set of pre-defined enum key formatting
    • Dropbox for changing a set of pre-defined property key formatting
    • Dropbox for changing a set of pre-defined model name formatting
  • Cleanup a bunch of duplicate code

Related issues

#1301 will fix the issue where some options are no longer visible.
Blocked by #1310

@netlify
Copy link

netlify bot commented May 22, 2023 •
edited
Loading

✅ Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 8535b06
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/64766c4a45d91a0008bed7d0
😎 Deploy Preview https://deploy-preview-1309--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jonaslagoni jonaslagoni mentioned this pull request May 22, 2023
Merged
@coveralls
Copy link

coveralls commented May 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5056358797

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.196%
Totals Coverage Status
Change from base Build 5055290417: 0.0%
Covered Lines: 5240
Relevant Lines: 5542
💛 - Coveralls

@jonaslagoni jonaslagoni mentioned this pull request May 30, 2023
Closed
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni merged commit b4cc721 into asyncapi:master May 30, 2023
@jonaslagoni jonaslagoni deleted the add_generic_playground_options branch May 30, 2023 21:48
@jonaslagoni jonaslagoni mentioned this pull request May 30, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonaslagoni @coveralls @asyncapi-bot