Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

feat: support v2.1.0 of spec #137

Merged

Conversation

magicmatatjahu
Copy link
Contributor

@magicmatatjahu magicmatatjahu commented Jun 29, 2021

Description

Support for 2.1.0 version of spec:

  • use latest version of html-template and markdown-template
  • use latest version of converter - convert to 2.1.0:
    • inform about 2.1.0 version when user uses the 2.0.0 on every half hour - maybe to change to 1h?

Example with 2.0.0 version:

image

Example with 2.1.0 version:

image

Related issue(s)
Part of asyncapi/spec#536

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Jun 29, 2021
fmvilas
fmvilas previously approved these changes Jun 29, 2021
Copy link
Contributor

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fmvilas
Copy link
Contributor

fmvilas commented Jun 29, 2021

There are some conflicts and checks failing.

@magicmatatjahu magicmatatjahu changed the title Suppor 2.1.0 Support v2.1.0 of spec Jun 29, 2021
@magicmatatjahu magicmatatjahu changed the title Support v2.1.0 of spec feat: support v2.1.0 of spec Jun 29, 2021
@magicmatatjahu
Copy link
Contributor Author

@fmvilas Thanks! Fixed!

fmvilas
fmvilas previously approved these changes Jun 29, 2021
derberg
derberg previously approved these changes Jun 29, 2021
Copy link
Contributor

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome
I would only ping user once a day and not every 30min 😄

@magicmatatjahu magicmatatjahu dismissed stale reviews from derberg and fmvilas via 2eaf1ab June 29, 2021 13:37
@magicmatatjahu
Copy link
Contributor Author

Thanks folks! 🚀

@magicmatatjahu magicmatatjahu merged commit c13cb4a into asyncapi-archived-repos:master Jun 29, 2021
@magicmatatjahu magicmatatjahu deleted the suppor-2.1.0 branch June 29, 2021 13:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants