Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update outdated and vulnerable packages #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tonyganchev
Copy link

Changes

  • All dev dependencies raised to latest versions.
  • Added rollup ^4.0.0 as a supported peer dependency.
  • Fixed typing errors in test.
  • Added myself as contributor

Leftovers

# npm audit report

request  *
Severity: moderate
Server-Side Request Forgery in Request - https://github.com/advisories/GHSA-p8p7-x288-28g6
Depends on vulnerable versions of tough-cookie
No fix available
node_modules/request
  coveralls  *
  Depends on vulnerable versions of request
  node_modules/coveralls

tough-cookie  <4.1.3
Severity: moderate
tough-cookie Prototype Pollution vulnerability - https://github.com/advisories/GHSA-72xf-g2v4-qvf3
No fix available
node_modules/tough-cookie

3 moderate severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

Testing

Ran the test included in the project.

Changes
---------
- All dev dependencies raised to latest versions.
- Added rollup ^4.0.0 as a supported peer dependency.
- Fixed typing errors in test.
- Added myself as contributor

Leftovers
----------
```
# npm audit report

request  *
Severity: moderate
Server-Side Request Forgery in Request - GHSA-p8p7-x288-28g6
Depends on vulnerable versions of tough-cookie
No fix available
node_modules/request
  coveralls  *
  Depends on vulnerable versions of request
  node_modules/coveralls

tough-cookie  <4.1.3
Severity: moderate
tough-cookie Prototype Pollution vulnerability - GHSA-72xf-g2v4-qvf3
No fix available
node_modules/tough-cookie

3 moderate severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.
```

Testing
--------
Ran the added test
@NickHeap2
Copy link

@bennypowers , @deebloo , @asyncLiz any chance of getting this merged so we can update rollup?
Or @tonyganchev did you find an alternative to this that is still supported?

@joryphillips
Copy link

joryphillips commented Oct 2, 2024

^
Friendly ping!
update: I switched to Vite instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants