Skip to content

Commit

Permalink
[clang-repl] Fix BUILD_SHARED_LIBS symbols from libclangInterpreter o…
Browse files Browse the repository at this point in the history
…n MinGW (#71393)

A few symbols within libclangInterpreter have got explicit dllexport
attributes, in order to make them exported (and thus visible at runtime)
in any build, not only when they are part of e.g. a DLL libclang-cpp,
but also when they are part of a plain .exe.

Due to the explicit dllexports, these symbols would sidestep the regular
MinGW logic of exporting all symbols if there are no dllexports.
Therefore, for libclang-cpp, a separate fix was made in
592e935, to pass --export-all-symbols
to the build of libclang-cpp.

If building with BUILD_SHARED_LIBS enabled, then the same issue appears
in libclangInterpreter; pass the same flag --export-all-symbols there as
well, to make sure all symbols are visible, not only the ones that are
explicitly marked as dllexport.

(cherry picked from commit 0d3eeac8c0f45410398a87f72ae38ea6ae1c3073)
  • Loading branch information
mstorsjo authored and tru committed Nov 13, 2023
1 parent 582f046 commit 910748f
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions clang/lib/Interpreter/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,14 @@ add_clang_library(clangInterpreter
clangSema
clangSerialization
)

if ((MINGW OR CYGWIN) AND BUILD_SHARED_LIBS)
# The DLLs are supposed to export all symbols (except for ones that are
# explicitly hidden). Normally, this is what happens anyway, but if there
# are symbols that are marked explicitly as dllexport, we'd only export them
# and nothing else. The Interpreter contains a few cases of such dllexports
# (for symbols that need to be exported even from standalone exe files);
# therefore, add --export-all-symbols to make sure we export all symbols
# despite potential dllexports.
target_link_options(clangInterpreter PRIVATE LINKER:--export-all-symbols)
endif()

0 comments on commit 910748f

Please sign in to comment.