Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lifecycle api #119

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Mar 3, 2022

update to the latest rclcpp_lifecycle api.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@icolwell-as
Copy link
Member

Thanks @wep21, can you provide a link to some documentation about ManagedEntityInterface? I can't seem to find much. Is ManagedEntityInterface available in ROS2 Foxy?

@wep21
Copy link
Contributor Author

wep21 commented Mar 3, 2022

@icolwell-as

can you provide a link to some documentation about ManagedEntityInterface?

This comes from ros2/rclcpp#1863

Is ManagedEntityInterface available in ROS2 Foxy?

No, I built this with ros2 rolling on Ubuntu22.04. This PR is a preparation for humble.

@icolwell-as
Copy link
Member

@wep21, thanks for the info. I will leave this PR open until we decide to release on Humble.

@wep21 wep21 force-pushed the rolling branch 2 times, most recently from 4d9b260 to a1cd8ad Compare May 13, 2022 09:10
@wep21
Copy link
Contributor Author

wep21 commented May 13, 2022

@icolwell-as I enabled build on both foxy and humble. Could you proceed to merge this PR?
Also is it possible to prepare pre-release repositry to put astuff ros packages for humble?

@icolwell-as
Copy link
Member

Hi @wep21, there's no need to have both foxy and humble builds at the same time on the master branch. Feel free to remove the #ifdefs so that only humble is supported.
In general, our master branches represent the latest ROS release, so now that humble is almost released, I've created a foxy branch such that the ros2_master branch can target humble.

Unfortunately we don't support any pre-release repos, but some time after humble is officially released, we will add ros-humble-pacmod3 to our https://s3.amazonaws.com/autonomoustuff-repo/.

@wep21
Copy link
Contributor Author

wep21 commented May 20, 2022

@icolwell-as

there's no need to have both foxy and humble builds at the same time on the master branch. Feel free to remove the #ifdefs so that only humble is supported.

I got it. I reverted backward support.

some time after humble is officially released, we will add ros-humble-pacmod3 to our https://s3.amazonaws.com/autonomoustuff-repo/.

Thanks. We also need pacmod3_msgs and kvaser_interface, so could you also add these packages into your repository?

@wep21
Copy link
Contributor Author

wep21 commented May 24, 2022

@icolwell-as Now, humble has been released. Please let me know if astuff humble packages are also available.

@icolwell-as
Copy link
Member

Hi @wep21, thanks for the update. At the moment I am targeting the end of next week (June 3rd) for Humble pacmod and kvaser packages. Since Humble is a long-term release we want to test in-vehicle before releasing.
Let me know if this timeline doesn't work for you.
Thanks!

@wep21
Copy link
Contributor Author

wep21 commented May 27, 2022

@icolwell-as

At the moment I am targeting the end of next week (June 3rd) for Humble pacmod and kvaser packages.

It's no problem for us. Thanks for letting me know the release plan.

Copy link
Member

@icolwell-as icolwell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested yesterday.

@icolwell-as icolwell-as merged commit af87400 into astuff:ros2_master Jun 3, 2022
@wep21 wep21 deleted the rolling branch June 3, 2022 18:44
@icolwell-as
Copy link
Member

@wep21: pacmod3, pacmod3_msgs, kvaser_interface, and pacmod_game_control are now released on humble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants