Remove support for (undocumented) --compiler argument #36
Conversation
ff7c5fc to
eaa29a6
Compare
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 74.16% 81.04% +6.87%
==========================================
Files 10 4 -6
Lines 511 269 -242
==========================================
- Hits 379 218 -161
+ Misses 132 51 -81
Continue to review full report at Codecov.
|
extension_helpers/_setup_helpers.py
Outdated
| def get_compiler(): | ||
| """ | ||
| Determines the compiler that will be used to build extension modules. | ||
|
|
||
| Returns | ||
| ------- | ||
| compiler : str | ||
| The compiler option specified for the build, build_ext, or build_clib | ||
| command; or the default compiler for the platform if none was | ||
| specified. | ||
|
|
||
| """ | ||
| return new_compiler().compiler_type | ||
|
|
There was a problem hiding this comment.
If this is the upshot of this change then +:100: because it will make #33 a lot easier.
There was a problem hiding this comment.
I mean at some point we can even deprecate get_compiler but no rush for that - given how simple it is
There was a problem hiding this comment.
We would need to provide a way to switch on compiler / platform though as different compilers can use different flags etc.
eaa29a6 to
8d53a34
Compare
Before this PR, we allowed the compiler returned by
get_compilerto be overridden by the--compilercommand-line argument. This wasn't actually documented and removing support for this allows us to clean up quite a bit of code.Needs to be rebased once #34 is merged!