Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to logging #448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SauravMaheshkar
Copy link

Change Description

closes #327

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

github-actions bot commented Jan 6, 2025

Before [e07916b] After [3d48c08] Ratio Benchmark (Parameter)
40.4±0.4ms 41.1±0.7ms 1.02 benchmarks.Suite.time_pixel_tree_creation
75.3±0.6ms 75.1±0.4ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
12.9±0.4ms 12.9±0.6ms 1 benchmarks.Suite.time_inner_pixel_alignment
362±1ms 361±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
113±1ms 113±1ms 1 benchmarks.time_test_alignment_even_sky
1.02±0.03ms 1.02±0.02ms 1 benchmarks.time_test_cone_filter_multiple_order
19.1±0.05ms 18.7±0.1ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6
75.6±0.6ms 74.4±0.6ms 0.98 benchmarks.MetadataSuite.time_load_partition_join_info

Click here to view all benchmarks.

@delucchi-cmu
Copy link
Contributor

Hi Saurav!

I triggered the workflows, but there were several failures. Our HATS contribution guide needs some updates, but you can follow the LSDB contribution guide for tips on setting up a development environment, and checks that should pass before sending for review.

If you have any questions, or want to expand your contributions, let's talk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change our warnings.warn calls to logging.info/warn
2 participants