Ensure use of float64 when calling radec2pix #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
In the function
healpix_shim.py.radec2pix
, convertra
anddec
to 64-bit floating point before attempting to callcdshealpix.lonlat_to_healpix
, which raises aTypeError
if it receives 32-bit floating point.Closes astronomy-commons/hats-import#458 .
Have verified this fix both with an updated unit test, and also by exercising the code in a separate build of a margin cache, which produced another instance of the above issue. This time, using a local checkout of this fix, the mapping phase continued past 5% without any instance of the error (which arose much earlier than the 5% mark before).
Code Quality
Bug Fix Checklist