Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass compression kwargs through file system open. #334

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Related to astronomy-commons/hats-import#369

Pandas does not infer compression when passed a file handle. Further, pandas will not use any compression kwarg passed if the input is a file handle. The compression needs to be handled when the file is opened (and it's now opened by the file system object, as of PR #315)

Copy link

github-actions bot commented Aug 12, 2024

Before [0459650] <v0.3.8> After [f8f9076] Ratio Benchmark (Parameter)
20.0±0.4ms 20.2±0.5ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order6
78.3±0.3ms 78.1±0.6ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
77.5±0.2ms 77.4±0.3ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
13.2±0.4ms 13.2±0.2ms 1 benchmarks.Suite.time_inner_pixel_alignment
371±2ms 372±4ms 1 benchmarks.Suite.time_outer_pixel_alignment
86.5±2ms 86.4±2ms 1 benchmarks.Suite.time_paths_creation
112±0.8ms 112±2ms 1 benchmarks.time_test_alignment_even_sky
41.2±0.6ms 40.8±0.6ms 0.99 benchmarks.Suite.time_pixel_tree_creation
996±20μs 969±4μs 0.97 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (0459650) to head (414e624).
Report is 73 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          58       58           
  Lines        2060     2060           
=======================================
  Hits         1934     1934           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 8139cbc into main Aug 13, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the import/issue/369 branch August 13, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants