Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility healpix functions to convert between order, average pixel size and minimum distance between edges #318

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

hombit
Copy link
Contributor

@hombit hombit commented Jul 30, 2024

This is needed for astronomy-commons/hats-import#358 implementation.

I'm not sure if I put it to the right module, please tell me if I should change it.

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit requested a review from delucchi-cmu July 30, 2024 12:37
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (8db1893) to head (c83c13c).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   93.85%   93.88%   +0.03%     
==========================================
  Files          58       58              
  Lines        2049     2060      +11     
==========================================
+ Hits         1923     1934      +11     
  Misses        126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 30, 2024

Before [8db1893] After [73d88dc] Ratio Benchmark (Parameter)
19.9±0.3ms 20.5±0.6ms 1.03 benchmarks.MetadataSuite.time_load_partition_info_order6
13.2±0.3ms 13.3±0.4ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
77.7±1ms 76.8±0.7ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
382±3ms 378±3ms 0.99 benchmarks.Suite.time_outer_pixel_alignment
119±1ms 118±0.3ms 0.99 benchmarks.time_test_alignment_even_sky
997±20μs 988±10μs 0.99 benchmarks.time_test_cone_filter_multiple_order
78.5±2ms 77.1±1ms 0.98 benchmarks.MetadataSuite.time_load_partition_join_info
42.5±0.6ms 41.8±0.3ms 0.98 benchmarks.Suite.time_pixel_tree_creation
89.2±2ms 86.7±2ms 0.97 benchmarks.Suite.time_paths_creation

Click here to view all benchmarks.

@hombit hombit force-pushed the avgsize_to_order branch from bc638d7 to c83c13c Compare July 30, 2024 13:45
Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as good a place as any!

@hombit hombit merged commit 0459650 into main Jul 31, 2024
11 of 12 checks passed
@hombit hombit deleted the avgsize_to_order branch July 31, 2024 12:43
@hombit hombit mentioned this pull request Jul 31, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants