-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store arrow schema when reading catalogs #310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 93.78% 93.84% +0.06%
==========================================
Files 58 58
Lines 2028 2048 +20
==========================================
+ Hits 1902 1922 +20
Misses 126 126 ☔ View full report in Codecov by Sentry. |
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this for index catalogs as well? Does it just not matter? They don't inherit from HealpixDataset, just that superclass Dataset.
When instantiating a catalog, extract the arrow schema from the metadata files and store it.
Code Quality