Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull resume logic into helper class. #95

Merged
merged 15 commits into from
Jul 12, 2023
Merged

Pull resume logic into helper class. #95

merged 15 commits into from
Jul 12, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Solution Description

  • Migrates handling of resume logging to a helper class
  • Removes filter function
  • Scatters file reader on map/split methods

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #95 (c0af007) into main (435e1d1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          825       876   +51     
=========================================
+ Hits           825       876   +51     
Impacted Files Coverage Δ
src/hipscat_import/catalog/__init__.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/arguments.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/file_readers.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/map_reduce.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/resume_plan.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/run_import.py 100.00% <100.00%> (ø)
src/hipscat_import/runtime_arguments.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the refactor! Few little things

src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a child branch where I was doing even more refactoring for zubercal imports. I've merged that branch in, as it neatly addresses most of your comments.

src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
src/hipscat_import/catalog/resume_plan.py Outdated Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 087754f into main Jul 12, 2023
@delucchi-cmu delucchi-cmu deleted the delucchi/resume branch July 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants