Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of association pipeline. #69

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Initial implementation of association pipeline. #69

merged 5 commits into from
Apr 21, 2023

Conversation

delucchi-cmu
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 18, 2023 •
edited
Loading

Codecov Report

Merging #69 (8fb830f) into main (cd602c5) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   99.13%   99.31%   +0.18%     
==========================================
  Files          11       15       +4     
  Lines         461      584     +123     
==========================================
+ Hits          457      580     +123     
  Misses          4        4
Impacted Files Coverage Δ
src/hipscat_import/association/__init__.py 100.00% <100.00%> (ø)
src/hipscat_import/association/arguments.py 100.00% <100.00%> (ø)
src/hipscat_import/association/map_reduce.py 100.00% <100.00%> (ø)
src/hipscat_import/association/run_association.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

smcguire-cmu
smcguire-cmu reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exciting to see it coming together!

src/hipscat_import/association/arguments.py Outdated Show resolved Hide resolved
src/hipscat_import/association/map_reduce.py Show resolved Hide resolved
src/hipscat_import/association/map_reduce.py Show resolved Hide resolved
src/hipscat_import/association/map_reduce.py Outdated Show resolved Hide resolved
src/hipscat_import/association/map_reduce.py Show resolved Hide resolved
tests/hipscat_import/association/test_association_argument.py Show resolved Hide resolved
src/hipscat_import/association/run_association.py Outdated Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit c07342f into main Apr 21, 2023
@delucchi-cmu delucchi-cmu mentioned this pull request Apr 24, 2023
Closed
@delucchi-cmu delucchi-cmu deleted the issue/41/association branch April 24, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcguire-cmu smcguire-cmu smcguire-cmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @smcguire-cmu