Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch verification #480

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Patch verification #480

merged 2 commits into from
Jan 27, 2025

Conversation

troyraen
Copy link
Collaborator

@troyraen troyraen commented Jan 25, 2025

Follow up to #428

Change Description

  • Move the code that generates unit test data to the designated notebook.
    • I simplified this code and removed some things that turned out not to be necessary. For example, it now uses fixed dummy data instead of generating random data. This resulted in changes to the data files, but none of those changes should affect the test results.
  • Add provenance info to the written report.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (6056af4) to head (777725b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   94.96%   94.97%           
=======================================
  Files          28       28           
  Lines        1809     1811    +2     
=======================================
+ Hits         1718     1720    +2     
  Misses         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@troyraen troyraen force-pushed the raen/patch/verification branch from d083658 to 777725b Compare January 25, 2025 03:35
@troyraen troyraen marked this pull request as ready for review January 25, 2025 03:45
@troyraen troyraen requested a review from delucchi-cmu January 25, 2025 03:46
@troyraen troyraen merged commit 201397c into main Jan 27, 2025
10 checks passed
@troyraen troyraen deleted the raen/patch/verification branch January 27, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants