Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform extra tests against empty files. #456

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Just checks that empty input files (both regular input, and indexed input) don't cause issues with the mapping or binning stages.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (2f9453c) to head (ac61891).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          28       28           
  Lines        1615     1615           
=======================================
  Hits         1527     1527           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delucchi-cmu delucchi-cmu merged commit 33aeacd into main Dec 10, 2024
10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/empty-test branch December 10, 2024 21:09
@delucchi-cmu delucchi-cmu mentioned this pull request Jan 23, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants