Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pylint import error. #448

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Disable pylint import error. #448

merged 2 commits into from
Dec 2, 2024

Conversation

delucchi-cmu
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.55%. Comparing base (acff6e8) to head (ef0ee23).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/hats_import/hipscat_conversion/run_conversion.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          28       28           
  Lines        1615     1615           
=======================================
  Hits         1527     1527           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 2, 2024

Before [acff6e8] <v0.4.2> After [2e88b4d] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delucchi-cmu delucchi-cmu merged commit 087d23f into main Dec 2, 2024
10 of 11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/import_error branch December 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants