Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pandas metadata in hipscat conversion #413

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Pandas metadata uses the old _hipscat_id field. Instead of manipulating the pandas metadata to fit new columns, just remove from the parquet schema.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.00%. Comparing base (5717268) to head (ebb816d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...c/hats_import/hipscat_conversion/run_conversion.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   99.06%   99.00%   -0.07%     
==========================================
  Files          29       29              
  Lines        1607     1609       +2     
==========================================
+ Hits         1592     1593       +1     
- Misses         15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 18, 2024

Before [5717268] <v0.4.0> After [aeb83c4] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit aeb92ae into main Oct 18, 2024
9 of 11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/parquet branch October 18, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants