Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use virtual environment when creating requirements file #410

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

delucchi-cmu
Copy link
Contributor

See reasoning and more details in #409

Copy link

Before [7e098c3] <v0.4.0> After [d1573cf] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (829fe47) to head (2d5824c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   99.73%   99.06%   -0.68%     
==========================================
  Files          26       29       +3     
  Lines        1520     1607      +87     
==========================================
+ Hits         1516     1592      +76     
- Misses          4       15      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 43ddae9 into main Oct 17, 2024
10 of 12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/venv branch October 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants