-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default margin order #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look again when checks are green.
f0596dd
to
aeea6d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 26 26
Lines 1457 1457
=======================================
Hits 1453 1453
Misses 4 4 ☔ View full report in Codecov by Sentry. |
aeea6d8
to
75b4c42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving, because github is being weird. And I'll also merge, as Kostya is on vacation.
Change the algorithm selecting the default margin order value: from being the smallest possible value (largest order of the catalog plus one) to be the largest possible value (so tiles would still include all objects within a given margin threshold).
Fixes #358
Change Description
Solution Description
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist