Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema to source data in SOAP pipeline #360

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

camposandro
Copy link
Collaborator

@camposandro camposandro commented Jul 30, 2024

Adds the arrow schema as an argument to the parquet reading of the source data files in the SOAP pipeline, which I missed in #348. It also fixes the documentation build, which is failing, by installing hipscat from source.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (aac8b9b) to head (766c767).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          26       26           
  Lines        1454     1454           
=======================================
  Hits         1450     1450           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camposandro camposandro requested a review from smcguire-cmu July 30, 2024 17:52
@camposandro camposandro merged commit 8a34d62 into main Jul 30, 2024
10 checks passed
@camposandro camposandro deleted the sandro/missing-schema-arg branch July 30, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants