Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up some resume functionality #324

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

A few clean-ups that don't change much functionality of resuming catalog, margin cache, or SOAP generation pipelines.

  • Moves delete_resume_log_files up to the super class, so all resume plans can use the argument.
  • Exposes user options for retaining intermediate files in margin generation and SOAP, as this was requested for catalog import and might be useful here as well.
  • Moves margin cache pixel calculation more into the planning stages. Reduces the scope of the variables, and the negative pixel calculation can count toward the "planning" phase time.
  • Only create directories for margin cache if the leaf files will be created.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (d27f650) to head (26596c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   99.55%   99.56%           
=======================================
  Files          26       26           
  Lines        1363     1370    +7     
=======================================
+ Hits         1357     1364    +7     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested a review from jeremykubica May 30, 2024 13:13
@delucchi-cmu delucchi-cmu merged commit 8145fbd into main May 30, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/resume_tidy branch May 30, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants