Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume functionality for margin cache pipeline. #321

Merged
merged 5 commits into from
May 29, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #313 .

Adds a resume plan to margin cache generation.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (daad9df) to head (0be0af1).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   99.53%   99.55%   +0.02%     
==========================================
  Files          25       26       +1     
  Lines        1296     1363      +67     
==========================================
+ Hits         1290     1357      +67     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested a review from camposandro May 28, 2024 18:56
@delucchi-cmu delucchi-cmu requested a review from camposandro May 29, 2024 15:37
@delucchi-cmu delucchi-cmu merged commit d27f650 into main May 29, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/313/resume branch May 29, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resume functionality for margin cache generation
2 participants