Get all file_reader provenance info programmatically #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Closes #304
Relies on astronomy-commons/hats#274
Updates the
provenance_info
method of the base classInputReader
to return all class attributes. Removes the method from child classes.This picks up attributes that were not previously being captured and results in some tests failing when the values cannot be json serialized. As far as I can tell, the best place to handle this is in
hipscat.io.write_metadata.HipscatEncoder
so I opened astronomy-commons/hats#274 to address it. Using that on my local machine, all tests pass.Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist