Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all file_reader provenance info programmatically #316

Merged
merged 1 commit into from
May 21, 2024

Conversation

troyraen
Copy link
Collaborator

@troyraen troyraen commented May 21, 2024

Change Description

Closes #304
Relies on astronomy-commons/hats#274

Updates the provenance_info method of the base class InputReader to return all class attributes. Removes the method from child classes.

This picks up attributes that were not previously being captured and results in some tests failing when the values cannot be json serialized. As far as I can tell, the best place to handle this is in hipscat.io.write_metadata.HipscatEncoder so I opened astronomy-commons/hats#274 to address it. Using that on my local machine, all tests pass.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@troyraen troyraen marked this pull request as ready for review May 21, 2024 14:51
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.52%. Comparing base (80991e9) to head (c488194).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   99.53%   99.52%   -0.01%     
==========================================
  Files          25       25              
  Lines        1284     1270      -14     
==========================================
- Hits         1278     1264      -14     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@troyraen troyraen merged commit 8b19bc2 into main May 21, 2024
9 checks passed
@troyraen troyraen deleted the issue/304/file_reader-provenance_info branch May 21, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use inferred member variable dictionary to create partition_info
2 participants