Handle case when triggered event is a new branch or a tag push #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremybeard
reviewed
Oct 28, 2024
action.yaml
Outdated
| DBT_DEPLOY=false | ||
|
|
||
| # case when the triggered event is a new tag creation, then we would need to deploy the dbt project to be on the safe side |
There was a problem hiding this comment.
nit: there is also a before null commit on pushing a new branch
There was a problem hiding this comment.
ohh yeah, good call to include that as well 👍
jeremybeard
reviewed
Oct 28, 2024
action.yaml
Outdated
| DBT_DEPLOY=false | ||
|
|
||
| # case when the triggered event is a new tag creation, then we would need to deploy the dbt project to be on the safe side |
There was a problem hiding this comment.
nit: "on the safe side" is a bit vague. We should say that we have to deploy the dbt project (or image below) because we cannot determine that it does not need to be deployed
jeremybeard
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the case when the before SHA for the triggered event is null (i.e. case when a new tag is pushed), in which case now we would do an image deploy and a dbt deploy (if configured), to be on the safe side.
Testing:
manually running the tests, since it is not straightforward to replicate the behavior in e2e tests. The below screenshot shows a run in a repo that had an "on tag" trigger event.
Reference: https://github.com/neel-astro/example-repo-update/actions/runs/11550491614/job/32145579388
Fixes: #82