Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize deployment workflow #1137

Merged
merged 2 commits into from
May 24, 2023
Merged

Optimize deployment workflow #1137

merged 2 commits into from
May 24, 2023

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented May 24, 2023

  • reduce the wait time to 30 minutes for providers-integration-tests-on-KE if providers-integration-tests is not deployed
  • merge wait for deployment and trigger master dag job into the same job but different step

Closes: #1136

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3c99745) 98.57% compared to head (ce622ef) 98.57%.

❗ Current head ce622ef differs from pull request most recent head 3ef35d4. Consider uploading reports for the commit 3ef35d4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          90       90           
  Lines        5339     5339           
=======================================
  Hits         5263     5263           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lee-W Lee-W force-pushed the optimize-deployment-workflow branch from 2c6763c to c628cd2 Compare May 24, 2023 09:40
Lee-W added 2 commits May 24, 2023 17:55
…integration-tests-on-KE if providers-integration-tests is not deployed

We currently wait for 2 hours 30 minutes even when providers-integration-tests is not deployed
the reason of the additional 2 hours is for waiting providers-integration-tests
…job into the same job but different step

Split them into different job will need to wasting additional resources on spinning up another runner
and there's no good reason to do so as of now
@Lee-W Lee-W force-pushed the optimize-deployment-workflow branch from ce622ef to 3ef35d4 Compare May 24, 2023 09:55
@Lee-W Lee-W merged commit c5ab6a7 into main May 24, 2023
@Lee-W Lee-W deleted the optimize-deployment-workflow branch May 24, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants