Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused docs dependency #1414

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Remove unused docs dependency #1414

merged 4 commits into from
Dec 27, 2024

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Dec 19, 2024

This PR clean-up requires dependency for building and publishing docs

Copy link

cloudflare-workers-and-pages bot commented Dec 19, 2024

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: f74d55d
Status:⚡️  Build in progress...

View logs

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (dada5cf) to head (3dfb3bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1414   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files          73       73           
  Lines        4320     4320           
=======================================
  Hits         4170     4170           
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit f74d55d
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/676e6047fbfbfd00087be769

@pankajastro pankajastro marked this pull request as ready for review December 20, 2024 15:35
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. area:dependencies Related to dependencies, like Python packages, library versions, etc labels Dec 20, 2024
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, @pankajastro ! This looks much better!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 27, 2024
@tatiana tatiana merged commit 7b3c5fa into main Dec 27, 2024
2 of 33 checks passed
@tatiana tatiana deleted the clean-docs-deps branch December 27, 2024 08:08
@tatiana tatiana added this to the Cosmos 1.8.1 milestone Dec 27, 2024
@pankajastro pankajastro mentioned this pull request Dec 30, 2024
pankajastro added a commit that referenced this pull request Dec 30, 2024
1.8.1 (2024-12-30)
--------------------

Bug Fixes

* Fix rendering dbt tests with multiple parents by @tatiana in #1433
* Add ``kwargs`` param in DocsOperator method
``upload_to_cloud_storage`` by @pankajastro in #1422

Docs

* Improve OpenLineage documentation by @tatiana in #1431

Others

* Enable Docs DAG in CI leveraging existing CI connections by
@pankajkoti in #1428
* Install providers with airflow by @pankajkoti in #1432
* Remove unused docs dependency by @pankajastro in #1414
* Pre-commit hook updates in #1424 

---------

Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Related to dependencies, like Python packages, library versions, etc lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants