Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netlify build timeouts #1294

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix Netlify build timeouts #1294

merged 2 commits into from
Oct 31, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Oct 31, 2024

Netlify jobs are failing during the "Initialization" step as seen in: https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67225eeb6eaeb400080afce5

With the error:

5:01:30 PM: Failed during stage 'Install dependencies': Command did not finish within the time limit
5:01:30 PM: Execution timed out after 17m59.815960796s
5:01:30 PM: Execution timed out after 17m59.917466353s
5:01:30 PM: Failing build: Failed to install dependencies

Dependency resolution is a pain. After confirming the dependencies that were taking longer, I pinned several of them, based on the constraints file: https://github.com/apache/airflow/blob/constraints-2.10.0/constraints-3.10.txt

This seems to have reduced the installation of the docs dependencies significantly:

Locally:

time pip install -r requirements.txt
42.67s

In Netlify, the Initialization step was reduced to less than 3 min:
https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/672364e906837e00087c53ac

Netlify jobs are failing during the "Initialization" step as seen in:
https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67225eeb6eaeb400080afce5

With the error:
```
5:01:30 PM: Failed during stage 'Install dependencies': Command did not finish within the time limit
5:01:30 PM: Execution timed out after 17m59.815960796s
5:01:30 PM: Execution timed out after 17m59.917466353s
5:01:30 PM: Failing build: Failed to install dependencies
```

Dependency resolution is a pain. After confirming the dependencies that were taking longer, I pinned several of them, based on the constraints file:
https://github.com/apache/airflow/blob/constraints-2.10.0/constraints-3.10.txt

And this seems to have reduced the installation of the docs dependencies significantly:

```
time pip install -r requirements.txt
42.67s
```
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
🔨 Latest commit b3cc801
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/672364f985245d0008c87dbd
😎 Deploy Preview https://deploy-preview-1294--sunny-pastelito-5ecb04.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tatiana tatiana marked this pull request as ready for review October 31, 2024 11:13
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. area:dependencies Related to dependencies, like Python packages, library versions, etc labels Oct 31, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 31, 2024
@tatiana tatiana merged commit 42a397f into main Oct 31, 2024
63 of 65 checks passed
@tatiana tatiana deleted the netlify-improvements branch October 31, 2024 12:55
@tatiana tatiana added this to the Cosmos 1.8.0 milestone Oct 31, 2024
@tatiana tatiana self-assigned this Oct 31, 2024
@tatiana tatiana mentioned this pull request Dec 17, 2024
tatiana added a commit that referenced this pull request Dec 20, 2024
**New Features**

* Support customizing Airflow operator arguments per dbt node by @wornjs
in #1339. [More
information](https://astronomer.github.io/astronomer-cosmos/getting_started/custom-airflow-properties.html).
* Support uploading dbt artifacts to remote cloud storages via callback
by @pankajkoti in #1389. [Read
more](https://astronomer.github.io/astronomer-cosmos/configuration/callbacks.html).
* Add support to ``TestBehavior.BUILD`` by @tatiana in #1377.
[Documentation](https://astronomer.github.io/astronomer-cosmos/configuration/testing-behavior.html).
* Add support for the "at" operator when using ``LoadMode.DBT_MANIFEST``
or ``CUSTOM`` by @benjy44 in #1372
* Add dbt clone operator by @pankajastro in #1326, as documented in
[here](https://astronomer.github.io/astronomer-cosmos/getting_started/operators.html).
* Support rendering tasks with non-ASCII characters by @t0momi219 in
#1278 [Read
more](https://astronomer.github.io/astronomer-cosmos/configuration/task-display-name.html)
* Add warning callback on source freshness by @pankajastro in #1400
[Read
more](https://astronomer.github.io/astronomer-cosmos/configuration/source-nodes-rendering.html#on-warning-callback-callback)
* Add Oracle Profile mapping by @slords and @pankajkoti in #1190 and
#1404
* Emit telemetry to Scarf during DAG run by @tatiana in #1397
* Save tasks map as ``DbtToAirflowConverter`` property by
@internetcoffeephone and @hheemskerk in #1362

**Bug Fixes**

* Fix the mock value of port in ``TrinoBaseProfileMapping`` to be an
integer by @dwolfeu #1322
* Fix access to the ``dbt docs`` menu item outside of Astro cloud by
@tatiana in #1312
* Add missing ``DbtSourceGcpCloudRunJobOperator`` in module
``cosmos.operators.gcp_cloud_run_job`` by @anai-s in #1290
* Support building ``DbtDag`` without setting paths in ``ProjectConfig``
by @tatiana in #1307
* Fix parsing dbt ls outputs that contain JSONs that are not dbt nodes
by @tatiana in #1296
* Fix Snowflake Profile mapping when using AWS default region by
@tatiana in #1406
* Fix dag rendering for taskflow + DbtTaskGroup combo by @pankajastro in
#1360

**Enhancements**

* Improve dbt command execution logs to troubleshoot ``None`` values by
@tatiana in #1392
* Add logging of stdout to dbt graph run_command by @KarolGongola in
#1390
* Save tasks map as DbtToAirflowConverter property by
@internetcoffeephone and @hheemskerk in #1362
* Support rendering build operator task-id with non-ASCII characters by
@pankajastro in #1415

**Docs**

* Remove extra ` char from docs by @pankajastro in #1345
* Add limitation about copying target dir files to remote by @pankajkoti
in #1305
* Generalise example from README by @ReadytoRocc in #1311
* Add security policy by @tatiana, @chaosmaw and @lzdanski in # 1385
* Mention in documentation that the callback functionality is supported
in ``ExecutionMode.VIRTUALENV`` by @pankajkoti in #1401

**Others**

* Restore Jaffle Shop so that ``basic_cosmos_dag`` works as documented
by @tatiana in #1374
* Remove Pytest durations from tests scripts by @tatiana in #1383
* Remove typing-extensions as dependency by @pankajastro in #1381
* Pin dbt-databricks version to < 1.9 by @pankajastro in #1376
* Refactor ``dbt-sqlite`` tests to use ``dbt-postgres`` by @pankajastro
in #1366
* Remove 'dbt-core<1.8.9' pin by @tatiana in #1371
* Remove dependency ``eval_type_backport`` by @tatiana in #1370
* Enable kubernetes tests for dbt>=1.8 by @pankajastro #1364
* CI Workaround: Pin dbt-core, Disable SQLite Tests, and Correctly
Ignore Clone Test to Pass CI by @pankajastro in #1337
* Enable Azure task in the remote store manifest example DAG by
@pankajkoti in #1333
* Enable GCP remote manifest task by @pankajastro in #1332
* Add exempt label option in GH action stale job by @pankajastro in
#1328
* Add integration test for source node rendering by @pankajastro in
#1327
* Fix vulnerability issue on docs dependency by @tatiana in #1313
* Add postgres pod status check for k8s tests in CI by @pankajkoti in
#1320
* [CI] Reduce the amount taking to run tests in the CI from 5h to 11min
by @tatiana in #1297
* Enable secret detection precommit check by @pankajastro in #1302
* Fix security vulnerability, by not pinning Airflow 2.10.0 by @tatiana
in #1298
* Fix Netlify build timeouts by @tatiana in #1294
* Add stalebot to label/close stale PRs and issues by @tatiana in #1288
* Unpin dbt-databricks version by @pankajastro in #1409
* Fix source resource type tests by @pankajastro in #1405
* Increase performance tests models by @tatiana in #1403
* Drop running 1000 models in the CI by @pankajkoti in #1411
* Fix releasing package to PyPI by @tatiana in #1396
* Pre-commit hook updates in #1394, #1373, #1358, #1340, #1331, #1314,
#1301

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Co-authored-by: Pankaj Singh <pankaj.singh@astronomer.io>

Closes: #1193

---------

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Related to dependencies, like Python packages, library versions, etc lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants