Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markupsafe from dependencies #623

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Remove markupsafe from dependencies #623

merged 2 commits into from
Aug 11, 2022

Conversation

utkarsharma2
Copy link
Collaborator

Description

What is the current behavior?

We might not need markupsafe package.

closes: #622

What is the new behavior?

remove it from pyprojects.py and try if our test cases pass without it.

Does this introduce a breaking change?

Nope

Checklist

  • All checks and tests in the CI should pass

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #623 (f96bb4c) into main (c675199) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          41       41           
  Lines        1672     1672           
  Branches      211      211           
=======================================
  Hits         1560     1560           
  Misses         89       89           
  Partials       23       23           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kaxil
Copy link
Collaborator

kaxil commented Aug 10, 2022

The reason it was pinned on Airflow was: apache/airflow@366c66b

Action items for you:

  • Identify how does this impact Airflow users -- which was the Airflow version when the upper bound on Airflow as lifted. how does that impact users with old Airflow version

@utkarsharma2
Copy link
Collaborator Author

utkarsharma2 commented Aug 10, 2022

@kaxil

Impact for users of Airflow = 2.2.3

This will impact the users of 2.2.3 but users can install airflow by using the following method
https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#installation-tools

Impact for users of Airflow >= 2.2.4

No impact

**Affected Airflow version - 2.2.3

Fix Airflow version - 2.2.4rc1 / 2.2.4**

History

Added in codebase
apache/airflow#12417

Issue caused
version - 2.2.3
Lift off upper bound for MarkupSafe
apache/airflow#20113

Issue Fixed
version - 2.2.4
Pin Markupsafe until we are able to upgrade Flask/Jinja
apache/airflow#21664

@kaxil
Copy link
Collaborator

kaxil commented Aug 11, 2022

Sounds good, feel free to merge it @utkarsharma2

Good work on the findings

@utkarsharma2 utkarsharma2 merged commit f7c07e5 into main Aug 11, 2022
@utkarsharma2 utkarsharma2 deleted the RemoveMarkupsafe branch August 11, 2022 12:47
kaxil pushed a commit that referenced this pull request Aug 18, 2022
Description
What is the current behavior?

We might not need markupsafe package.

closes: #622
What is the new behavior?

remove it from pyprojects.py and try if our test cases pass without it.
Does this introduce a breaking change?

Nope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if we can Remove markupsafe
4 participants