This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Address follow up comments on PR #66 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=======================================
Coverage 77.40% 77.40%
=======================================
Files 6 6
Lines 624 624
Branches 88 88
=======================================
Hits 483 483
Misses 114 114
Partials 27 27 ☔ View full report in Codecov by Sentry. |
tatiana
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Thanks, @pankajkoti, for addressing my late comments!
As part of the release PR, let's add some docs so people know about this environment variable.
Moving forward, we could consider setting the version in the api_client, to avoid to having to define it per request - not a blocker for this PR or the release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.