Add click-compatible kerberos command #1499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankehly
commented
Jun 16, 2022
hankehly
commented
Jun 16, 2022
|
@blag Please review this PR at your earliest convenience. |
blag
suggested changes
Jun 16, 2022
airflow/cli/commands/kerberos.py
Outdated
| @click.option("-k", "--keytab", metavar="KEYTAB", help="keytab", default=conf.get("kerberos", "keytab")) | ||
| def kerberos(principal, stdout, stderr, pid, daemon_, log_file, keytab): | ||
| """Start a kerberos ticket renewer""" | ||
| print(settings.HEADER) |
There was a problem hiding this comment.
Suggested change
| print(settings.HEADER) | |
| from rich.console import Console | |
| console = Console() | |
| console.print(settings.HEADER) |
Ideally all output would flow through rich.console.Console.
There was a problem hiding this comment.
Excellent, I'll remember that. Here's the before (bottom) and after (top)
|
Thank you for all of the work you've done for this. From this discussion, there is more groundwork and research necessary before we can evaluate rewriting the CLI with Click. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: apache#22708
Summary
This PR adds click-compatible
kerberoscommand.Todo:
Screenshots (before/after)