Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom collective transforms #239

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

CosmoMatt
Copy link
Collaborator

@CosmoMatt CosmoMatt commented Oct 25, 2024

@jasonmcewen this PR builds on the Fourier-Wigner precompute transform work and implements custom transforms which collectively transform:

  • Subsets of Wigner coefficients (collection of spin spherical harmonic coefficients) to collection of spin signals on sphere
  • Collection of spin signals on sphere to their spin spherical harmonic coefficients (stable wrt spin and can accept duplicated spins as per multimodal data)
  • Signal on SO(3) on a subset of its Wigner coefficients (subset of spin spherical harmonic coefficients).

These are all the core transforms we will need going forward.

@CosmoMatt CosmoMatt requested a review from jasonmcewen October 25, 2024 10:07
@CosmoMatt CosmoMatt self-assigned this Oct 25, 2024
@CosmoMatt CosmoMatt added enhancement New feature or request blocker Blocking other or upcoming tasks labels Oct 25, 2024
Copy link
Contributor

@jasonmcewen jasonmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @CosmoMatt, just a few minor comments. Have approved so you can merge once these addressed.

s2fft/precompute_transforms/custom_ops.py Show resolved Hide resolved
s2fft/precompute_transforms/custom_ops.py Outdated Show resolved Hide resolved
s2fft/precompute_transforms/custom_ops.py Outdated Show resolved Hide resolved
s2fft/precompute_transforms/custom_ops.py Outdated Show resolved Hide resolved
s2fft/precompute_transforms/custom_ops.py Show resolved Hide resolved
s2fft/precompute_transforms/custom_ops.py Outdated Show resolved Hide resolved
s2fft/precompute_transforms/custom_ops.py Outdated Show resolved Hide resolved
s2fft/precompute_transforms/custom_ops.py Outdated Show resolved Hide resolved
s2fft/precompute_transforms/custom_ops.py Outdated Show resolved Hide resolved
@CosmoMatt CosmoMatt merged commit f6e10a0 into main Nov 11, 2024
2 checks passed
@CosmoMatt CosmoMatt deleted the map/hybrid-risbo-transforms branch November 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Blocking other or upcoming tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants