Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUF] - Add unnecessary dict comprehension for iterable rule (RUF023) #9612

Closed
wants to merge 2 commits into from

Conversation

mikeleppane
Copy link
Contributor

Summary

Checks for unnecessary dict comprehension when creating a new dictionary from iterable. Suggest to replace with dict.fromkeys(iterable)

See: #9592

Test Plan

cargo test

Copy link

codspeed-hq bot commented Jan 22, 2024

CodSpeed Performance Report

Merging #9612 will degrade performances by 4.61%

Comparing mikeleppane:add-RUF023 (9e7b476) with main (a3d667e)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mikeleppane:add-RUF023 Change
linter/all-with-preview-rules[numpy/ctypeslib.py] 26.4 ms 27.7 ms -4.61%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants