Introduce Token element #7048
Merged
Introduce Token element #7048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
3ed2546 to
2e61a54
Compare
MichaReiser
commented
Sep 1, 2023
| /// indent(&format_args![ | ||
| /// hard_line_break(), | ||
| /// text("indent level 1"), | ||
| /// token("indent level 1"), |
There was a problem hiding this comment.
This is arguably worse because these aren't really tokens but having a text builder just for the examples feels overkill (and the examples don't violate any constraint)
2e61a54 to
ce2b166
Compare
ce2b166 to
e1e047f
Compare
|
Cool! I like the rename of dynamic_text to text as well |
charliermarsh
approved these changes
Sep 1, 2023
Merged
fc0d6aa to
409f8f9
Compare
denbezrukov
reviewed
Sep 22, 2023
| fmt.debug_tuple("DynamicText").field(text).finish() | ||
| } | ||
| FormatElement::Token { text } => fmt.debug_tuple("Token").field(text).finish(), | ||
| FormatElement::Text { text, .. } => fmt.debug_tuple("DynamicText").field(text).finish(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces
StaticTextwith a stricterTokenelementThis proves to be sufficient for the
textusages in Ruff's formatter today (and probably all code formatters) and has the advantage that the formatter can take shortcuts for these strings.I thought about introducing a new
Tokenelement instead of replacingText. But we don't really have any use case for it other than doctests, which doesn't justify adding a new format element.Feedback welcome on
Should we rename
dynamic_texttotext?Test Plan
cargo testPerformance
This improves performance between 2-3%