Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter: Small RParen refactoring #5885

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Formatter: Small RParen refactoring #5885

merged 1 commit into from
Jul 20, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Jul 19, 2023

Summary

A bit more consistency inspired by #5882 (comment)

Test Plan

Existing tests (refactoring)

@konstin
Copy link
Member Author

konstin commented Jul 19, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@konstin konstin force-pushed the Fix_slice_formatting_with_parentheses branch from e062233 to 46b65d0 Compare July 19, 2023 15:16
@konstin konstin force-pushed the rparens-skipping branch from 7442727 to b658ba6 Compare July 19, 2023 15:16
Base automatically changed from Fix_slice_formatting_with_parentheses to main July 19, 2023 15:25
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      9.3±0.03ms     4.4 MB/sec    1.01      9.4±0.04ms     4.3 MB/sec
formatter/numpy/ctypeslib.py               1.00   1861.1±1.87µs     8.9 MB/sec    1.01   1875.9±3.88µs     8.9 MB/sec
formatter/numpy/globals.py                 1.00    207.3±0.88µs    14.2 MB/sec    1.01    209.6±1.99µs    14.1 MB/sec
formatter/pydantic/types.py                1.00      4.0±0.01ms     6.4 MB/sec    1.01      4.0±0.01ms     6.3 MB/sec
linter/all-rules/large/dataset.py          1.00     13.1±0.10ms     3.1 MB/sec    1.00     13.1±0.07ms     3.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.3±0.01ms     5.1 MB/sec    1.00      3.3±0.03ms     5.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    429.4±0.69µs     6.9 MB/sec    1.00    430.8±0.79µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.01      5.9±0.03ms     4.3 MB/sec    1.00      5.9±0.04ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.01      6.7±0.03ms     6.1 MB/sec    1.00      6.6±0.02ms     6.2 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01   1421.1±1.81µs    11.7 MB/sec    1.00   1411.2±2.23µs    11.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    157.0±0.29µs    18.8 MB/sec    1.00    157.2±0.23µs    18.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.01ms     8.5 MB/sec    1.00      3.0±0.01ms     8.6 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     10.9±0.09ms     3.7 MB/sec    1.05     11.4±0.08ms     3.6 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.2±0.05ms     7.7 MB/sec    1.05      2.3±0.03ms     7.4 MB/sec
formatter/numpy/globals.py                 1.00    243.0±4.28µs    12.1 MB/sec    1.05    254.7±9.28µs    11.6 MB/sec
formatter/pydantic/types.py                1.00      4.7±0.05ms     5.5 MB/sec    1.06      4.9±0.06ms     5.2 MB/sec
linter/all-rules/large/dataset.py          1.00     15.1±0.11ms     2.7 MB/sec    1.01     15.3±0.11ms     2.7 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.0±0.04ms     4.2 MB/sec    1.01      4.0±0.04ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    482.9±6.52µs     6.1 MB/sec    1.01    486.3±6.06µs     6.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.9±0.05ms     3.7 MB/sec    1.01      6.9±0.06ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.00      8.0±0.06ms     5.1 MB/sec    1.01      8.0±0.05ms     5.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1662.4±15.41µs    10.0 MB/sec    1.00  1663.7±18.21µs    10.0 MB/sec
linter/default-rules/numpy/globals.py      1.00    188.5±2.75µs    15.7 MB/sec    1.01    190.8±4.04µs    15.5 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.03ms     7.2 MB/sec    1.01      3.6±0.04ms     7.1 MB/sec

@konstin konstin force-pushed the rparens-skipping branch from b658ba6 to 409a94d Compare July 19, 2023 17:25
@konstin konstin merged commit 8c5f8a8 into main Jul 20, 2023
@konstin konstin deleted the rparens-skipping branch July 20, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants