Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mode from BestFitting #5609

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Remove mode from BestFitting #5609

merged 1 commit into from
Jul 11, 2023

Conversation

MichaReiser
Copy link
Member

Summary

This PR removes the mode field from BestFitting because it is no longer used (we now use conditional_group and `fits_expanded).

Test Plan

cargo test

This was referenced Jul 8, 2023
Merged
Merged
@MichaReiser
Copy link
Member Author

MichaReiser commented Jul 8, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser added the formatter Related to the formatter label Jul 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      8.1±0.07ms     5.0 MB/sec    1.00      8.0±0.02ms     5.1 MB/sec
formatter/numpy/ctypeslib.py               1.00   1869.6±1.69µs     8.9 MB/sec    1.00   1866.4±4.10µs     8.9 MB/sec
formatter/numpy/globals.py                 1.00    207.1±0.24µs    14.2 MB/sec    1.00    207.2±0.87µs    14.2 MB/sec
formatter/pydantic/types.py                1.00      4.0±0.00ms     6.4 MB/sec    1.00      4.0±0.02ms     6.4 MB/sec
linter/all-rules/large/dataset.py          1.00     13.5±0.06ms     3.0 MB/sec    1.00     13.4±0.04ms     3.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.00ms     4.9 MB/sec    1.00      3.4±0.02ms     4.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    432.1±0.69µs     6.8 MB/sec    1.00    433.5±0.68µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.0±0.01ms     4.3 MB/sec    1.01      6.0±0.03ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.00      6.7±0.01ms     6.1 MB/sec    1.00      6.7±0.02ms     6.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1464.2±4.04µs    11.4 MB/sec    1.00  1468.5±10.69µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.01    166.8±0.26µs    17.7 MB/sec    1.00    165.8±0.32µs    17.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.01ms     8.4 MB/sec    1.00      3.0±0.01ms     8.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      9.3±0.08ms     4.4 MB/sec    1.00      9.3±0.06ms     4.4 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.1±0.06ms     7.9 MB/sec    1.01      2.1±0.06ms     7.8 MB/sec
formatter/numpy/globals.py                 1.00    235.9±3.64µs    12.5 MB/sec    1.01    239.2±5.87µs    12.3 MB/sec
formatter/pydantic/types.py                1.00      4.6±0.06ms     5.6 MB/sec    1.01      4.6±0.07ms     5.6 MB/sec
linter/all-rules/large/dataset.py          1.00     15.7±0.11ms     2.6 MB/sec    1.00     15.7±0.10ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.05ms     4.0 MB/sec    1.00      4.1±0.04ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00    504.1±7.14µs     5.9 MB/sec    1.00    503.1±5.30µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.1±0.06ms     3.6 MB/sec    1.00      7.1±0.05ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.1±0.07ms     5.0 MB/sec    1.00      8.1±0.05ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1714.2±15.22µs     9.7 MB/sec    1.00  1712.2±14.78µs     9.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    201.9±5.26µs    14.6 MB/sec    1.00    202.0±4.08µs    14.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.03ms     7.0 MB/sec    1.00      3.6±0.03ms     7.0 MB/sec

@MichaReiser MichaReiser force-pushed the expand-by-parentheses-first branch from 5dda384 to c97caf1 Compare July 8, 2023 15:43
@MichaReiser MichaReiser force-pushed the remove-best-fitting-mode branch from 64a377d to b7b5fce Compare July 8, 2023 15:43
@MichaReiser MichaReiser mentioned this pull request Jul 8, 2023
Closed
@MichaReiser MichaReiser force-pushed the expand-by-parentheses-first branch from c97caf1 to 537c84f Compare July 9, 2023 11:11
@MichaReiser MichaReiser force-pushed the remove-best-fitting-mode branch from b7b5fce to fa060af Compare July 9, 2023 11:12
@MichaReiser MichaReiser force-pushed the expand-by-parentheses-first branch from 537c84f to 56bae34 Compare July 9, 2023 11:22
@MichaReiser MichaReiser force-pushed the remove-best-fitting-mode branch from fa060af to e1d01dd Compare July 9, 2023 11:22
@MichaReiser MichaReiser force-pushed the expand-by-parentheses-first branch from 56bae34 to aa6915d Compare July 10, 2023 08:37
@MichaReiser MichaReiser force-pushed the remove-best-fitting-mode branch 3 times, most recently from f8ab5b3 to b64751f Compare July 10, 2023 11:43
@MichaReiser MichaReiser force-pushed the expand-by-parentheses-first branch from 8803400 to 074d289 Compare July 10, 2023 12:01
@MichaReiser MichaReiser force-pushed the remove-best-fitting-mode branch from b64751f to f06aa8e Compare July 10, 2023 12:01
This was referenced Jul 10, 2023
Merged
Closed
Merged
@MichaReiser MichaReiser force-pushed the expand-by-parentheses-first branch from 074d289 to b8dff47 Compare July 11, 2023 06:56
@MichaReiser MichaReiser force-pushed the remove-best-fitting-mode branch from f06aa8e to 0c7c03d Compare July 11, 2023 06:56
@MichaReiser MichaReiser mentioned this pull request Jul 11, 2023
Merged
@MichaReiser MichaReiser mentioned this pull request Jul 11, 2023
Merged
@MichaReiser MichaReiser force-pushed the expand-by-parentheses-first branch from b8dff47 to 830edb6 Compare July 11, 2023 11:30
@MichaReiser MichaReiser force-pushed the remove-best-fitting-mode branch from 0c7c03d to b754a0d Compare July 11, 2023 11:30
Base automatically changed from expand-by-parentheses-first to main July 11, 2023 12:07
@MichaReiser
Copy link
Member Author

Graphite rebased this pull request as part of a merge.

@MichaReiser MichaReiser force-pushed the remove-best-fitting-mode branch from b754a0d to 51c4306 Compare July 11, 2023 12:10
@MichaReiser MichaReiser merged commit 9a8ba58 into main Jul 11, 2023
@MichaReiser
Copy link
Member Author

@MichaReiser merged this pull request with Graphite.

@MichaReiser MichaReiser deleted the remove-best-fitting-mode branch July 11, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
formatter Related to the formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaReiser @charliermarsh @konstin