-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUF009 should behave similar to B008 and ignore attributes with immutable types #16048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutes with immutable types
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
RUF009 | 12 | 0 | 12 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -12 violations, +0 -0 fixes in 2 projects; 53 projects unchanged)
apache/airflow (+0 -8 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- airflow/models/dag.py:432:25: RUF009 Do not perform function call in dataclass defaults - airflow/models/dag.py:433:24: RUF009 Do not perform function call `airflow_conf.get_mandatory_value` in dataclass defaults - dev/breeze/src/airflow_breeze/params/common_build_params.py:61:31: RUF009 Do not perform function call `os.environ.get` in dataclass defaults - dev/breeze/src/airflow_breeze/params/common_build_params.py:62:27: RUF009 Do not perform function call `os.environ.get` in dataclass defaults - dev/breeze/src/airflow_breeze/params/common_build_params.py:64:25: RUF009 Do not perform function call `os.environ.get` in dataclass defaults - dev/breeze/src/airflow_breeze/params/shell_params.py:151:31: RUF009 Do not perform function call `os.environ.get` in dataclass defaults - dev/breeze/src/airflow_breeze/params/shell_params.py:164:27: RUF009 Do not perform function call `os.environ.get` in dataclass defaults - dev/breeze/src/airflow_breeze/params/shell_params.py:166:25: RUF009 Do not perform function call `os.environ.get` in dataclass defaults
latchbio/latch (+0 -4 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview
- src/latch_cli/exceptions/handler.py:23:23: RUF009 Do not perform function call `platform.version` in dataclass defaults - src/latch_cli/exceptions/handler.py:24:26: RUF009 Do not perform function call `get_local_package_version` in dataclass defaults - src/latch_cli/exceptions/handler.py:26:21: RUF009 Do not perform function call `platform.platform` in dataclass defaults - src/latch_sdk_config/latch.py:86:22: RUF009 Do not perform function call `urljoin` in dataclass defaults
Changes by rule (1 rules affected)
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
RUF009 | 12 | 0 | 12 | 0 | 0 |
Thank you |
dcreager
added a commit
that referenced
this pull request
Feb 10, 2025
* main: (991 commits) [red-knot] Resolve `Options` to `Settings` (#16000) Bump version to 0.9.6 (#16074) Revert tailwindcss v4 update (#16075) Improve migration document (#16072) Fix reference definition labels for backtick-quoted shortcut links (#16035) RUF009 should behave similar to B008 and ignore attributes with immutable types (#16048) [`pylint`] Also report when the object isn't a literal (`PLE1310`) (#15985) Update Rust crate rustc-hash to v2.1.1 (#16060) Root exclusions in the server to project root (#16043) Directly include `Settings` struct for the server (#16042) Update Rust crate clap to v4.5.28 (#16059) Update Rust crate strum_macros to 0.27.0 (#16065) Update NPM Development dependencies (#16067) Update Rust crate uuid to v1.13.1 (#16066) Update Rust crate strum to 0.27.0 (#16064) Update pre-commit dependencies (#16063) Update dependency ruff to v0.9.5 (#16062) Update Rust crate toml to v0.8.20 (#16061) [`flake8-builtins`] Make strict module name comparison optional (`A005`) (#15951) [`ruff`] Indented form feeds (`RUF054`) (#16049) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolved #15772
Before PR:
After PR: