Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply AIR302-context check only in @task function #15711

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Jan 24, 2025

This PR updates AIR302 to only apply the context keys check in @task decorated function.

Ref: #15144

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jan 24, 2025
@dhruvmanila
Copy link
Member Author

cc @sunank200 @Lee-W

Copy link
Contributor

github-actions bot commented Jan 24, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila force-pushed the dhruv/airflow-refactor branch from 4ff54bc to cf39dcc Compare January 24, 2025 07:25
@dhruvmanila dhruvmanila enabled auto-merge (squash) January 24, 2025 07:27
@dhruvmanila dhruvmanila merged commit 99d8ec6 into main Jan 24, 2025
41 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/airflow-refactor branch January 24, 2025 07:30
@Lee-W
Copy link
Contributor

Lee-W commented Jan 24, 2025

HI @dhruvmanila , #15713 this should fix part of the issues.

dcreager added a commit that referenced this pull request Jan 24, 2025
* main:
  Add `check` command (#15692)
  [red-knot] Use itertools to clean up `SymbolState::merge` (#15702)
  [red-knot] Add `--ignore`, `--warn`, and `--error` CLI arguments (#15689)
  Use `uv init --lib` in tutorial (#15718)
  [red-knot] Use `Unknown | T_inferred` for undeclared public symbols (#15674)
  [`ruff`] Parenthesize fix when argument spans multiple lines for `unnecessary-round` (`RUF057`) (#15703)
  [red-knot] Rename `TestDbBuilder::typeshed` to `.custom_typeshed` (#15712)
  Honor banned top level imports by TID253 in PLC0415.  (#15628)
  Apply `AIR302`-context check only in `@task` function (#15711)
  [`airflow`] Update `AIR302` to check for deprecated context keys (#15144)
  Remove test rules from JSON schema (#15627)
  Add two missing commits to changelog (#15701)
  Fix grep for version number in docker build (#15699)
  Bump version to 0.9.3 (#15698)
  Preserve raw string prefix and escapes (#15694)
  [`flake8-pytest-style`] Rewrite references to `.exception` (`PT027`) (#15680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants