[pyupgrade] Handle multiple base classes for PEP 695 generics (UP046)
#15659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
9ff1143 to
fcca976
Compare
fcca976 to
14c1835
Compare
update snaps
I thought I deleted this before
14c1835 to
e458749
Compare
ntBre
commented
Jan 22, 2025
crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
Outdated
Show resolved
Hide resolved
AlexWaygood
approved these changes
Jan 22, 2025
crates/ruff_linter/resources/test/fixtures/pyupgrade/UP046_0.py
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
ntBre
commented
Jan 22, 2025
crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
Outdated
Show resolved
Hide resolved
AlexWaygood
approved these changes
Jan 22, 2025
crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Jan 22, 2025
crates/ruff_linter/src/rules/pyupgrade/rules/pep695/non_pep695_generic_class.rs
Outdated
Show resolved
Hide resolved
7 tasks
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
dcreager
added a commit
that referenced
this pull request
Jan 24, 2025
* main: [red-knot] MDTests: Do not depend on precise public-symbol type inference (#15691) [red-knot] Make `infer.rs` unit tests independent of public symbol inference (#15690) Tidy knot CLI tests (#15685) [red-knot] Port comprehension tests to Markdown (#15688) Create Unknown rule diagnostics with a source range (#15648) [red-knot] Port 'deferred annotations' unit tests to Markdown (#15686) [red-knot] Support custom typeshed Markdown tests (#15683) Don't run the linter ecosystem check on PRs that only touch red-knot crates (#15687) Add `rules` table to configuration (#15645) [red-knot] Make `Diagnostic::file` optional (#15640) [red-knot] Add test for nested attribute access (#15684) [red-knot] Anchor relative paths in configurations (#15634) [`pyupgrade`] Handle multiple base classes for PEP 695 generics (`UP046`) (#15659) [`pyflakes`] Treat arguments passed to the `default=` parameter of `TypeVar` as type expressions (`F821`) (#15679) Upgrade zizmor to the latest version in CI (#15649) [`pyupgrade`] Add rules to use PEP 695 generics in classes and functions (`UP046`, `UP047`) (#15565) [red-knot] Ensure a gradual type can always be assigned to itself (#15675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the second follow up to #15565 in #15642. This was easier than expected by using this cool destructuring syntax I hadn't used before, and by assuming PYI059 (
generic-not-last-base-class).Test Plan
Using an existing test, plus two new tests combining multiple base classes and multiple generics. It looks like I deleted a relevant test, which I did, but I meant to rename this in #15565. It looks like instead I copied it and renamed the copy.