[flake8-type-checking
] Fix some safe fixes being labeled unsafe
#15638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were mistakenly using
CommentRanges::has_comments
to determine whether our editswere safe, which sometimes expands the checked range to the end of a line. But in order to
determine safety we need to check exactly the range we're replacing.
This bug affected the rules
runtime-cast-value
(TC006
) andquoted-type-alias
(TC008
)although it was very unlikely to be hit for
TC006
and forTC008
we never hit it because wewere checking the wrong expression.
Test Plan
cargo nextest run