[red-knot] 'is_equivalent_to' is an equivalence relation #15488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two additional tests for `is_equivalent_to` so that we cover all properties of an [equivalence relation]. [equivalence relation]: https://en.wikipedia.org/wiki/Equivalence_relation
sharkdp
commented
Jan 15, 2025
| @@ -365,7 +378,7 @@ mod flaky { | |||
|
|
|||
| // For two fully static types, their intersection must be a subtype of each type in the pair. | |||
| type_property_test!( | |||
| all_fully_static_type_pairs_are_supertypes_of_their_union, db, | |||
| all_fully_static_type_pairs_are_supertypes_of_their_intersection, db, | |||
There was a problem hiding this comment.
Unrelated minor fix.
|
dcreager
reviewed
Jan 15, 2025
| // Transitivity: If `S` is equivalent to `T` and `T` is equivalent to `U`, then `S` must be equivalent to `U`. | ||
| type_property_test!( | ||
| equivalent_to_is_transitive, db, | ||
| forall types s, t, u. s.is_equivalent_to(db, t) && t.is_equivalent_to(db, u) => s.is_equivalent_to(db, u) |
There was a problem hiding this comment.
I love the syntax of these property tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds two additional tests for
is_equivalent_toso that we cover all properties of an equivalence relation.Test Plan