Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flatten to improve deserialization error messages #15414

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Jan 11, 2025

Summary

Closes: #9719

Test Plan

Before:

ruff failed
  Cause: Failed to parse /Users/dhruv/playground/ruff/pyproject.toml
  Cause: TOML parse error at line 22, column 1
   |
22 | [tool.ruff.lint]
   | ^^^^^^^^^^^^^^^^
invalid type: string "false", expected a boolean

After:

ruff failed
  Cause: Failed to parse /Users/dhruv/playground/ruff/pyproject.toml
  Cause: TOML parse error at line 27, column 20
   |
27 | mypy-init-return = "false"
   |                    ^^^^^^^
invalid type: string "false", expected a boolean

@dhruvmanila dhruvmanila force-pushed the dhruv/flatten-options branch from 44bef26 to 8235836 Compare January 11, 2025 06:26
@dhruvmanila dhruvmanila added the configuration Related to settings and configuration label Jan 11, 2025
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@dhruvmanila dhruvmanila marked this pull request as ready for review January 11, 2025 16:37
@dhruvmanila dhruvmanila merged commit 38f873b into main Jan 11, 2025
21 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/flatten-options branch January 11, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Related to settings and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOML parse error source reference is unhelpful
2 participants