Insert the cells from the start
position
#15398
Merged
+121
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cause of this bug is from #12575 which was itself a bug fix but the fix wasn't completely correct.
fixes: #14768
fixes: astral-sh/ruff-vscode#644
fixes: astral-sh/ruff-vscode#573
Test Plan
Consider the following three cells:
The test case is moving cell 2 to the top i.e., cell 2 goes to position 1 and cell 1 goes to position 2.
Before this fix, it can be seen that the cells were pushed at the end of the vector:
After the fix in this PR, it can be seen that the cells are being pushed at the correct
start
index: