[ruff
] Stop parsing diagnostics from other sources for code action requests
#15373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR stops
ruff server
attempting to parse diagnostic data for diagnostics from other language servers.The issue
When using
ruff server
withtypos-lsp
inhelix
, it is impossible to apply code actions suggested bytypos-lsp
.The cause
During a
textDocument/codeAction
request, the editor will sendDiagnostic
s toruff server
as part of thecodeActionContext
- these may have been generated by other LSP servers.According to the spec, the
Diagnostic.data
field can contain any data. However,ruff server
attempts to parse all contextual diagnostics, and assumes thedata
field adheres to the data structure used byruff server
.Since other language servers are free to use their own data structure, parsing the diagnostics fails causing an error, which ultimately causes the code action request to fail.
The fix
On code action requests,
ruff server
should only parse contextual diagnostics generated byruff server
.